provided by Star2Billing S.L.

It's possible to get the database into an inconsistent state using the User GUI alone:
1) Admin: create a new DID
2) User: allocate the new DID to your card
3) User: EDIT your newly allocated DID and choose someone else's DID
At this point Admin->DID->List Destination shows two destinations with the same DID.

Unless I'm misunderstanding something the "Release DID" option is superfluous; allocated DIDs are released using the DELETE button next to them aren't they?

There's also a couple of less dangerous bugs when deleting a DID:
i) on the "if you really want to remove" confirmation screen the DID details shown are not necessarily for your card, although the correct record will be removed from the cc_did_destination table.
ii) After releasing the DID it's not set back to reserved='0', iduser='0', so the DID is not available to be allocated again. This particular bug also affects the Admin UI.

Stavros,

Please point me where to look for these options in the code, and if I manage to fix them, I'll post the solution here.

I'm not a programmer, but I'm willing to try at least.

I've been trying to figure out exactly what needs changing myself. Starting from around line 176 of A2B_entity_did.php may help. It may also hinder.

A quick and dirty work around is to put the numbers for each users in a DID group. This buys me time to figure out where the drop down list is populated.

regards

I will take a look and let you know.

The would be great. I searched for a SQL query, but couldn't find one. It's no doubt an invalid where clause, but I couldn't find the code where the drop down got populated.

regards

Guys, let's celebrate. I have just fixed it. And discovered another bug that I have fixed to. The second bug was in the admin interface under DID usage.

Show: Dids in use (.) All Dids ( )

The show Dids in use was not accurately showing the correct DIDs.

In the customer interface, when you edit your DID, you will only be able to see DID's that you have purchases and that are assigned to your cardnumber.

I am making the patch right now against the trunk.

Oh, I have also hidden the "Delete" button. Cause there is no point delete a DID without releasing it. Cause that's what happen. You delete it, it will disappear from your DID list, but the DID is not released.

You're the man, asiby. I look forward to the patch.

I thought the same too initially, but I think I found the DID is released later by cron job.

Guys, here are the patches.

1. FG_var_diduse.inc.patch.tar.txt is for the admin interface. Make sure to move in the appropriate folder before running the command





2. FG_var_did.inc.patch.tar.txt is for the customer interface. Make sure to move in the appropriate folder before running the command



I will submit it to the track too.

I was just looking more closely at the problem of the delete button under the DID menu of the Customer UI. The truth is, on that page, the list called " - DID LIST -" should rather be called "Destination List". That particular fact makes users think that deleting what they believe to be a DID, they will also release that DID. But in fact, they would be deleting a destination. That will leave that DID without a destination until they choose to add a destination by clicking on the link "Add Phone Number to your DID".

Long story to say that I have reactivated the "delete" button in the patch and that I have changed the naming scheme to reflect that of the destinations instead of the DIDs.

[EDIT] : FG_var_diduse.inc.patch.txt reflects now the changes made by Stavros later in this thread.

Thanks for your time looking at this Asiby.

The fix comitted at r432 and r433 fixes this problem to my satisfaction.

Hello,

thanks for your work asiby,

but what the exact directory please ?

thank you

See here for the 'final' fix.

Thanks always for your help.

But I haven't understand what must I do to resolve the problem of did.

How can I proceed please ?

I do the changes directly or I download the files ?

It really depends on where you have decided to install the Admin UI and the Customer UI

/Path_To_Admin_UI/Public/form_data/FG_var_diduse.inc

and

/Path_To_Customer_UI/form_data/FG_var_did.inc

The directories are highlighted in red. Use cd to change directories until you are at the right place and apply the patch as described earlier.

Thank you for your response but I must do all the changes of this http://trac.asterisk2billing.org/cgi-bi ... =%2F%40431 after I patch ?
Because I patched the files without make any change.