provided by Star2Billing S.L.

If I setup an monthly charge for DID use, customer is billed for every DID on system.

Not good!

If someone can give me a clue as to where this is actioned I'll attempt to fix it. My guess it's another missing where clause

regards

Really?!?
This hadn't been reported to me as a problem before, and I've got a couple of customers running DIDs for a few months now.
I receive an email once a month from the DID cron job telling me how many accounts had balance deducted. The DID Billing view confirms exactly what was deducted from each card, and all seems to be in order there too.

This isn't in the DID billing, but in the billing menu, add charge menu.

I have a situation where I have customers with international DID's which I need to bill for. Adding a charge here causes a real problem, believe me. I've just spent an hour removing these entries from the database.

It only happens on DID monthly charge. All the other types are fine
regards

I think most of the code is in form_data/FG_var_charge.inc

Added after 8 minutes:

Yes, I think your initial guess was spot on. The clause to match the username is only invoked if the variable $filterprefix is not null. I can't find where $filterprefix might be defined.

Added after 6 minutes:

Actually $filter_prefix should be set by the framework when the cardnumber field is populated.

I'm getting there. I firmly believe it's in the SQL of the invoice forms.

There's a problem with this select. For 1 row in the table it returns 16 in the query result

SELECT t1.amount, t1.creationdate, t1.description, t3.countryname, t2.did, t1.currency FROM cc_charge t1 LEFT JOIN (cc_did t2, cc_country t3 ) ON ( t1.id_cc_did = t2.id AND t2.id_cc_country = t3.id ) WHERE (t1.chargetype = 1 OR t1.chargetype = 2) AND t1.id_cc_card = 1;

DB entry seems fine

Update

I've re-written the query and it now works as expected.



I'll update the others and post fix to trac

I fix the problem on my box by changing LEFT to INNER. Example: