Hanging Up before authentication= Call Goes Through *FIXED*

za3toor · **Joined:** Sat Aug 16, 2008 5:15 am **Posts:** 10

Hey Guys... this is my first Post, and I have been reading and learning so much from this forum for the past 3 weeks.

I have to say you guys did an AMAZING job with this wonderfull tool. I have changed it most of it is code to act as a Voip Service Provider. which is working great so far, but I got a couple of Issues.

Ill start with biggest issue i Have.

as of right now, I have it on DeadAGI, and when a customer makes an outbound call using a trunk, if he hangs up Before the authentication, A2Billing Makes the call and the destination rings, eventhough the Customer has already hungup.

this problem gets fixed if i used AGI in the extensions.conf insted of the DeadAGI, but the problem with this setup is that if the customer makes a call and HANG's UP FIRST, the call does not get charged and the Database does not get updated.

i can post some logs if need it.

Thanks for your help

za3toor

stavros · **Posted:** Mon Aug 18, 2008 5:17 pm

za3toor wrote:

I have changed it most of it is code to act as a Voip Service Provider.

What did you need to change exactly? Would you care to share your improvements back to the project? Obviously we can't support code we've never seen.

Quote:

as of right now, I have it on DeadAGI, and when a customer makes an outbound call using a trunk, if he hangs up Before the authentication, A2Billing Makes the call and the destination rings, eventhough the Customer has already hungup.

I recall having seen this situation once before, but it was a long time ago and the details escape me. Are you running A2B v1.3.3? This may be an issue we've already fixed. Are you sure A2B is placing the outbound leg? After all if no-one has authenticated A2B won't even know which callplan/trunk to use for the call. Are you sure it's not some Asterisk dialplan which is being executed after A2B has exited?

Quote:

this problem gets fixed if i used AGI in the extensions.conf insted of the DeadAGI, ... if the customer makes a call and HANG's UP FIRST, the call does not get charged and the Database does not get updated.

Yes this is expected behaviour. You must use DeadAGI() for A2B to have any chance of billing correctly.

Quote:

i can post some logs if need it.

Make sure you 'set verbose 15' in Asterisk first. 'debug = 3' in a2billing.conf might yield additional clues.

za3toor · **Joined:** Sat Aug 16, 2008 5:15 am **Posts:** 10

Quote:

What did you need to change exactly? Would you care to share your improvements back to the project? Obviously we can't support code we've never seen.

Sure, when it is 100% working with no bugs,

Quote:

recall having seen this situation once before, but it was a long time ago and the details escape me. Are you running A2B v1.3.3?

Yes i am using the latest Version.

Quote:

Are you sure A2B is placing the outbound leg?

Yes because it is the only code in the Context, and all of the sip peers are pointed to that context

Code:

[a2billing]
;exten => _X.,1,Answer
exten => _X.,1,Wait(1)
exten => _X.,n,DeadAGI(a2billing.php|1)
;exten => _X.,n,AGI(a2billing.php|1)
exten => _X.,n,Wait(1)
exten => _X.,n,Hangup

here are the LOG for the scneario where I called an outbound number and hangup right away, did not even hear how log i can talk for, and the call went through.

Code:

jroper · **Joined:** Fri Jun 23, 2006 3:56 pm **Posts:** 4065

Hi

If you let us see the code, we might be able to see any bugs and help you fix them, and incorporate your changes, if they are of value to the wider community.

In respect of the call being delivered, even if you have hungup, are you sure that Asterisk is actually hanging up when you hangup. Test this outside of A2Billing first.

Joe

za3toor · **Joined:** Sat Aug 16, 2008 5:15 am **Posts:** 10

Hey,

Thanks for your reply,

Quote:

Test this outside of A2Billing first.

I did tested and it works as expected, I have created another Context that dials outbound anything i dial using a trunk.
If i dial and wait it rings on the other end using that trunk, and if I dial and hang up right away while it is authenticating, the call gets terminated.

i found the same issue when calling between 2 extensions/sip users using the A2B context

if i call an extension and wait the call rings, and if i call and hang up while it is authenticating, the call goes through to the other extension even theough the first extension has already hangup.

Thanks

za3toor · **Joined:** Sat Aug 16, 2008 5:15 am **Posts:** 10

Hey guys... I have an Idea....

at approx line 1040 in file Class.A2Billing.php

Code:

$myres = $agi->exec("Dial $dialstr");

so i wanted to add an if statement.... like

Code:

if(Check_Caller_Channel){
$myres = $agi->exec("Dial $dialstr");
}

and i can't seem to find anything that would let me determine the value of the Check_Caller_Channel in AGI.

is there any variable that can be used to determine the status of the Caller Channel in DeadAGI?

thanks...

za3toor

stavros · **Posted:** Tue Aug 19, 2008 11:29 pm

You can use PHPAGI to ask Asterisk the status of the channel.

za3toor · **Joined:** Sat Aug 16, 2008 5:15 am **Posts:** 10

Thanks for your reply,

But i can't seem to get it to work,

i tried

Code:

if($agi->channel_status()){
$myres = $agi->exec("Dial $dialstr");
}

am i missing something?

how can i output the value of $agi->channel_status() to the console VERBOSE debug?

Thanks

stavros · **Posted:** Wed Aug 20, 2008 12:46 pm

za3toor wrote:

how can i output the value of $agi->channel_status() to the console VERBOSE debug?

See the lines of code before and after that line which you are changing. They show how to log something to the two different log destinations. Also see a few lines further down for examples of how to read and store the values of channel variables (DIALSTATUS and ANSWEREDTIME specifically).

za3toor · **Joined:** Sat Aug 16, 2008 5:15 am **Posts:** 10

Thanks A Lot... FINALLY i got it to work

it was a simple change....

in the a2billing.conf file

i had

Code:

answer_call = no

so when i changed it to

Code:

answer_call = yes

everything worked again...

no i can hang up after authentication and my trunk wont dial the number unless i stay on the line after authentication....

za3toor · **Joined:** Sat Aug 16, 2008 5:15 am **Posts:** 10

hey guys... after a good 3 weeks of hard work... i found the complete workaround it. FINALLY....

in Class.Rateengine.PHP

change from

Code:

$myres = $agi->exec("Dial $dialstr");

To

Code:

         $agi->wait_for_digit(5000);
         $channelcheck = $agi-> stream_file('was-last-seen', '#');
         
         if($channelcheck["result"]==0){
         $myres = $agi->exec("Dial $dialstr");   
         }

It will play an empty sound file. If played successful, the execution of the DIAL app will run, if not.. it wont dial.

Make sure that you have the above file in the sounds directory.

The file above can be changed to anything you want...I.E. Please wait while we connect your call...

Thanks for everyone who helped

and

Enjoy

vulcan · **Joined:** Mon Jan 08, 2007 6:56 pm **Posts:** 345

Code:

as of right now, I have it on DeadAGI, and when a customer makes an outbound call using a trunk, if he hangs up Before the authentication, A2Billing Makes the call and the destination rings, eventhough the Customer has already hungup.

You are authenticating on caller-id!! A2B runs off immediately, so it's hard for you to hangup before authentication.

This is an old feature of A2b so i'm sure it works well. The ringing you hear is probably a fake ring due to "R" on the dial command. Besides, Asterisk will terminate the SIP channels if the caller hangs up.

Correct me if I'm wrong, but isnt A2b already setup so you can use it as a service provider? Look for "WHOLESALE" in this forum.

Added after 1 hours 11 minutes:

Just to add ... DeadAGI will attempt to run even though the inbound has hung up, but this is how DeadAGI was designed to work_ to do housekeeping after an inbound channel has hung up. this depends too on "number_try =".

If you want both legs of the call to terminate immediately then use AGI but you will need to upgrade asterisk to the new Asterisk 1.6.0 beta9. AGI in Asterisk 1.2 and 1.4 does not work properly with A2b.

I've tried it and it works well. Arguable the best version of Asterisk out there!!!!! no problems yet. NO freepbx/trixbox just manual config of the default sample config files in plain linux.

Actually one problem I noticed is that the "stun server feature" still needs work. I dont use it.

provided by Star2Billing S.L.

Hanging Up before authentication= Call Goes Through FIXED

Who is online