Support A2Billing :

provided by Star2Billing S.L.

Support A2Billing :
It is currently Tue Sep 17, 2019 4:59 pm
Auto Dialer Software


All times are UTC




Post new topic Reply to topic  [ 4 posts ] 
Author Message
 Post subject: Coding standards
PostPosted: Fri Feb 10, 2012 11:38 pm 
Offline

Joined: Mon Dec 20, 2010 6:22 pm
Posts: 8
I'm finding this project hard to work with sometimes, because of the lack of consistency in the code base. Indentation, braces placement, commenting styles, whitespace usage, all are very different from one function to the next, or even within the same function!

Two questions: is there any documentation on coding standards for this project, and would you accept some cleanup patches if I went ahead and submitted them on github? Or is this something already on your radar, maybe for 2.0?

Thanks for the great work so far!


Top
 Profile  
 
 Post subject: Re: Coding standards
PostPosted: Sat Feb 11, 2012 10:42 am 
Offline

Joined: Sun Mar 12, 2006 2:49 pm
Posts: 954
Location: Barcelona
I totally agree with you, A2Billing has been under development for 8 years, and styles have changed, we received contributions by a huge number of peoples.
Patches to fix code style will be more than welcome.

Yours,
/Areski


Top
 Profile  
 
 Post subject: Re: Coding standards
PostPosted: Sat Sep 01, 2012 12:38 am 
Offline

Joined: Mon Dec 20, 2010 6:22 pm
Posts: 8
areski wrote:
I totally agree with you, A2Billing has been under development for 8 years, and styles have changed, we received contributions by a huge number of peoples.
Patches to fix code style will be more than welcome.

Yours,
/Areski


Here's a start: https://github.com/Star2Billing/a2billing/pull/29


Top
 Profile  
 
 Post subject: Re: Coding standards
PostPosted: Thu Sep 06, 2012 11:46 am 
Offline

Joined: Sun Mar 12, 2006 2:49 pm
Posts: 954
Location: Barcelona
Hi,

Great start! I merged your patch!


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 
Predictive Dialer


All times are UTC


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group