| asterisk2billing.org http://forum.asterisk2billing.org/ |
|
| Coding standards http://forum.asterisk2billing.org/viewtopic.php?f=18&t=9556 |
Page 1 of 1 |
| Author: | miken32 [ Fri Feb 10, 2012 11:38 pm ] |
| Post subject: | Coding standards |
I'm finding this project hard to work with sometimes, because of the lack of consistency in the code base. Indentation, braces placement, commenting styles, whitespace usage, all are very different from one function to the next, or even within the same function! Two questions: is there any documentation on coding standards for this project, and would you accept some cleanup patches if I went ahead and submitted them on github? Or is this something already on your radar, maybe for 2.0? Thanks for the great work so far! |
|
| Author: | areski [ Sat Feb 11, 2012 10:42 am ] |
| Post subject: | Re: Coding standards |
I totally agree with you, A2Billing has been under development for 8 years, and styles have changed, we received contributions by a huge number of peoples. Patches to fix code style will be more than welcome. Yours, /Areski |
|
| Author: | miken32 [ Sat Sep 01, 2012 12:38 am ] |
| Post subject: | Re: Coding standards |
areski wrote: I totally agree with you, A2Billing has been under development for 8 years, and styles have changed, we received contributions by a huge number of peoples. Patches to fix code style will be more than welcome. Yours, /Areski Here's a start: https://github.com/Star2Billing/a2billing/pull/29 |
|
| Author: | areski [ Thu Sep 06, 2012 11:46 am ] |
| Post subject: | Re: Coding standards |
Hi, Great start! I merged your patch! |
|
| Page 1 of 1 | All times are UTC |
| Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group http://www.phpbb.com/ |
|