Wow, graher01, it's great to see you contributing.
Can I ask that in future you supply your changes in patch/diff format, as it's much easier to see what was changed that way. Also the forum frequently ruins the formatting. It's as easy as this:
Code:
cp a2billing.php a2billing.php.orig
# edit a2billing.php
diff -u a2billing.php.orig a2billing.php > mypatch.diff.txt
You can attach that .txt to a forum post. If you want to attach code to an enhancement/defect on Trac then it's best to use just .diff as the extension, as Trac will then display it with markup making the changes even more obvious.
Additionally I've a few comments about your changes themselves.
Was there a reason you removed part of the code that splits the task into pages of 5,000 customers? It's intended to give the SQL server and the mailserver an easier time by sleeping after each page.
I'm not sure your 4th parameter to mail() is correct. It specifies a header line, so must be a valid SMTP header. Perhaps you meant "From:
[email protected]"?
I think you meant '$card_gen' rather than '$gen_card'.
Good work though. I'm always pleased to see another contributor.
my a2billing_check_account.php modified don't works.