a2billing_batch_process.php possible bug?

ferdorna · **Joined:** Wed Mar 10, 2010 5:42 pm **Posts:** 47

Hello A2B Team,
Playing arround with recurring services I noticed something in a2billing_batch_process.php file. Could this be a bug?

Here is the extract (the first column indicates the line number):

Code:

155         if (($rule == 2) && ($rule_day > 0)) {
156                 $filter .= " -- Apply service if card used in last y days
157                                 AND UNIX_TIMESTAMP(lastuse) >= UNIX_TIMESTAMP(CURRENT_TIMESTAMP) - $oneday \n";

This $filter variable is taking into account only cards used in the last 24 hours. I think the correct sentence for line 157 should be:

Code:

157                                 AND UNIX_TIMESTAMP(lastuse) >= UNIX_TIMESTAMP(CURRENT_TIMESTAMP) - $oneday * $rule_day \n";

where $rule_day represents the amount of "last y days"

Am I wrong?

Thank you!
Fernando

ferdorna · **Joined:** Wed Mar 10, 2010 5:42 pm **Posts:** 47

Hello....please anyone...tell me if I am wrong....

Regards!
Fernando

ferdorna · **Joined:** Wed Mar 10, 2010 5:42 pm **Posts:** 47

In addition, I propose to include the clause "AND status=1" in the sql query to avoid applying the recurr service to expired cards. Is this OK?

Regards!
Fernando

meral · **Joined:** Mon Apr 21, 2008 1:58 pm **Posts:** 16

you are wrong
this script must be executed every day
so it check state only 1 day before.
ur script can have more issues.

provided by Star2Billing S.L.

a2billing_batch_process.php possible bug?

Who is online